Compare Modrinth versions by release date, warn if inconsistent with version numbers

modrinth/install.go

@@ -200,7 +200,7 @@ func installViaSearch(query string, versionFilename string, autoAcceptFirst bool
 }
 
 func installProject(project *modrinthApi.Project, versionFilename string, pack core.Pack, index *core.Index) error {
-	latestVersion, err := getLatestVersion(*project.ID, pack)
+	latestVersion, err := getLatestVersion(*project.ID, *project.Title, pack)
 	if err != nil {
 		return fmt.Errorf("failed to get latest version: %v", err)
 	}
@@ -294,7 +294,7 @@ func installVersion(project *modrinthApi.Project, version *modrinthApi.Version,
 						return errors.New("failed to get dependency data: invalid response")
 					}
 					// Get latest version - could reuse version lookup data but it's not as easy (particularly since the version won't necessarily be the latest)
-					latestVersion, err := getLatestVersion(*project.ID, pack)
+					latestVersion, err := getLatestVersion(*project.ID, *project.Title, pack)
 					if err != nil {
 						return fmt.Errorf("failed to get latest version of dependency %v: %v", *project.ID, err)
 					}

modrinth/modrinth.go

@@ -227,7 +227,40 @@ func parseSlugOrUrl(input string, slug *string, version *string, versionID *stri
 	return
 }
 
-func getLatestVersion(projectID string, pack core.Pack) (*modrinthApi.Version, error) {
+func findLatestVersion(versions []*modrinthApi.Version, useFlexVer bool) *modrinthApi.Version {
+	latestValidVersion := versions[0]
+	latestValidLoaderIdx := getMinLoaderIdx(versions[0].Loaders)
+	for _, v := range versions[1:] {
+		var compare int32
+		if useFlexVer {
+			// Use FlexVer to compare versions
+			compare = flexver.Compare(*v.VersionNumber, *latestValidVersion.VersionNumber)
+		}
+
+		if compare == 0 {
+			loaderIdx := getMinLoaderIdx(v.Loaders)
+			// Prefer loaders; principally Quilt over Fabric, mods over datapacks (Modrinth backend handles filtering)
+			if loaderIdx < latestValidLoaderIdx {
+				latestValidVersion = v
+				latestValidLoaderIdx = loaderIdx
+				continue
+			}
+
+			// FlexVer comparison is equal, compare date instead
+			if v.DatePublished.After(*latestValidVersion.DatePublished) {
+				latestValidVersion = v
+				latestValidLoaderIdx = getMinLoaderIdx(v.Loaders)
+			}
+		} else if compare > 0 {
+			latestValidVersion = v
+			latestValidLoaderIdx = getMinLoaderIdx(v.Loaders)
+		}
+	}
+
+	return latestValidVersion
+}
+
+func getLatestVersion(projectID string, name string, pack core.Pack) (*modrinthApi.Version, error) {
 	mcVersion, err := pack.GetMCVersion()
 	if err != nil {
 		return nil, err
@@ -250,34 +283,15 @@ func getLatestVersion(projectID string, pack core.Pack) (*modrinthApi.Version, e
 		return nil, errors.New("no valid versions found\nUse the acceptable-game-versions option to accept more game versions\nTo use datapacks, add a datapack loader mod and specify the datapack-folder option with the folder this mod loads datapacks from")
 	}
 
-	latestValidVersion := result[0]
+	// TODO: option to always compare using flexver?
-	latestValidLoaderIdx := getMinLoaderIdx(result[0].Loaders)
+	// TODO: ask user which one to use?
-	for _, v := range result[1:] {
+	flexverLatest := findLatestVersion(result, true)
-		// Use FlexVer to compare versions
+	releaseDateLatest := findLatestVersion(result, false)
-		compare := flexver.Compare(*v.VersionNumber, *latestValidVersion.VersionNumber)
+	if flexverLatest != releaseDateLatest && releaseDateLatest.VersionNumber != nil && flexverLatest.VersionNumber != nil {
-
+		fmt.Printf("Warning: Modrinth versions for %s inconsistent between version numbers and release dates (%s newer than %s)\n", name, *releaseDateLatest.VersionNumber, *flexverLatest.VersionNumber)
-		if compare == 0 {
-			loaderIdx := getMinLoaderIdx(v.Loaders)
-			// Prefer loaders; principally Quilt over Fabric, mods over datapacks (Modrinth backend handles filtering)
-			if loaderIdx < latestValidLoaderIdx {
-				latestValidVersion = v
-				latestValidLoaderIdx = loaderIdx
-				continue
-			}
-
-			// FlexVer comparison is equal, compare date instead
-			// TODO: flag to force comparing by date?
-			if v.DatePublished.After(*latestValidVersion.DatePublished) {
-				latestValidVersion = v
-				latestValidLoaderIdx = getMinLoaderIdx(v.Loaders)
-			}
-		} else if compare > 0 {
-			latestValidVersion = v
-			latestValidLoaderIdx = getMinLoaderIdx(v.Loaders)
-		}
 	}
 
-	return latestValidVersion, nil
+	return releaseDateLatest, nil
 }
 
 func getSide(mod *modrinthApi.Project) string {

modrinth/updater.go

@@ -47,7 +47,7 @@ func (u mrUpdater) CheckUpdate(mods []core.Mod, mcVersion string, pack core.Pack
 
 		data := rawData.(mrUpdateData)
 
-		newVersion, err := getLatestVersion(data.ProjectID, pack)
+		newVersion, err := getLatestVersion(data.ProjectID, mod.Name, pack)
 		if err != nil {
 			results[i] = core.UpdateCheck{Error: fmt.Errorf("failed to get latest version: %v", err)}
 			continue