Correctly handle import/export of .disabled (optional disabled) mods

curseforge/export.go

@@ -54,7 +54,11 @@ var exportCmd = &cobra.Command{
 			// TODO: how to handle files with CF metadata, but with different download path?
 			if ok {
 				p := projectRaw.(cfUpdateData)
-				cfFileRefs = append(cfFileRefs, packinterop.AddonFileReference{ProjectID: p.ProjectID, FileID: p.FileID})
+				cfFileRefs = append(cfFileRefs, packinterop.AddonFileReference{
+					ProjectID:        p.ProjectID,
+					FileID:           p.FileID,
+					OptionalDisabled: mod.Option != nil && mod.Option.Optional && !mod.Option.Default,
+				})
 			} else {
 				// If the mod doesn't have the metadata, save it into the zip
 				path, err := filepath.Rel(filepath.Dir(indexPath), mod.GetDestFilePath())

curseforge/packinterop/manifest.go

@@ -54,6 +54,7 @@ func (c cursePackMeta) Mods() []AddonFileReference {
 		list[i] = AddonFileReference{
 			ProjectID:        v.ProjectID,
 			FileID:           v.FileID,
+			OptionalDisabled: !v.Required,
 		}
 	}
 	return list

curseforge/packinterop/minecraftinstance.go

@@ -21,6 +21,8 @@ type twitchInstalledPackMeta struct {
 		File struct {
 			// I've given up on using this cached data, just going to re-request it
 			ID int `json:"id"`
+			// Used to determine if the mod is optional-disabled
+			FileNameOnDisk string
 		} `json:"installedFile"`
 	} `json:"installedAddons"`
 	// Used to determine if modpackOverrides should be used or not
@@ -53,6 +55,7 @@ func (m twitchInstalledPackMeta) Mods() []AddonFileReference {
 		list[i] = AddonFileReference{
 			ProjectID:        v.ID,
 			FileID:           v.File.ID,
+			OptionalDisabled: strings.HasSuffix(v.File.FileNameOnDisk, ".disabled"),
 		}
 	}
 	return list

curseforge/packinterop/translation.go

@@ -61,10 +61,12 @@ func ReadMetadata(s ImportPackSource) ImportPackMetadata {
 	return packImport
 }
 
-// AddonFileReference is a pair of Project ID and File ID to reference a single file on CurseForge
+// AddonFileReference is a struct to reference a single file on CurseForge
 type AddonFileReference struct {
 	ProjectID int
 	FileID    int
+	// OptionalDisabled is true if the file is optional and disabled (turned off in Twitch launcher)
+	OptionalDisabled bool
 }
 
 func WriteManifestFromPack(pack core.Pack, fileRefs []AddonFileReference, out io.Writer) error {
@@ -79,7 +81,7 @@ func WriteManifestFromPack(pack core.Pack, fileRefs []AddonFileReference, out io
 			ProjectID int  `json:"projectID"`
 			FileID    int  `json:"fileID"`
 			Required  bool `json:"required"`
-		}{ProjectID: fr.ProjectID, FileID: fr.FileID, Required: true}
+		}{ProjectID: fr.ProjectID, FileID: fr.FileID, Required: !fr.OptionalDisabled}
 	}
 
 	modLoaders := make([]modLoaderDef, 0, 1)