mirrors/packwiz
1
0
Fork 0
mirror of https://github.com/packwiz/packwiz.git synced 2025-04-19 21:16:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make most Modrinth dep errors non-fatal, improve err message (fixes #201)

Browse Source
This commit is contained in:
comp500 2023-03-15 02:41:35 +00:00
parent 1786e47806
commit 433218e3cf
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modrinth/install.go
View File

@ -296,7 +296,8 @@ func installVersion(project *modrinthApi.Project, version *modrinthApi.Version,
// Get latest version - could reuse version lookup data but it's not as easy (particularly since the version won't necessarily be the latest) // Get latest version - could reuse version lookup data but it's not as easy (particularly since the version won't necessarily be the latest)
latestVersion, err := getLatestVersion(*project.ID, *project.Title, pack) latestVersion, err := getLatestVersion(*project.ID, *project.Title, pack)
if err != nil { if err != nil {
return fmt.Errorf("failed to get latest version of dependency %v: %v", *project.ID, err) fmt.Printf("Failed to get latest version of dependency %v: %v\n", *project.Title, err)
continue
} }
for _, dep := range version.Dependencies { for _, dep := range version.Dependencies {

2
modrinth/modrinth.go
View File

@ -287,7 +287,7 @@ func getLatestVersion(projectID string, name string, pack core.Pack) (*modrinthA
} }
if len(result) == 0 { if len(result) == 0 {
// TODO: retry with datapack specified, to determine what the issue is? or just request all and filter afterwards // TODO: retry with datapack specified, to determine what the issue is? or just request all and filter afterwards
return nil, errors.New("no valid versions found\nUse the acceptable-game-versions option to accept more game versions\nTo use datapacks, add a datapack loader mod and specify the datapack-folder option with the folder this mod loads datapacks from") return nil, errors.New("no valid versions found\n\tUse the acceptable-game-versions option to accept more game versions\n\tTo use datapacks, add a datapack loader mod and specify the datapack-folder option with the folder this mod loads datapacks from")
} }
// TODO: option to always compare using flexver? // TODO: option to always compare using flexver?