mirrors/packwiz
1
0
Fork 0
mirror of https://github.com/packwiz/packwiz.git synced 2025-11-18 17:14:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix minecraft version 1.21.1 pulling in NeoForge versions for 1.21.10 (#370)

Browse Source 
Since the compatibility check only verified that the first characters matched
between the version strings, a one-character patch version could be
misinterpreted if a two-character patch version existed.
This commit is contained in:
Karcsesz
2025-11-01 18:43:17 +01:00
committed by GitHub
parent adfe66935c
commit 2e214a45de
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/versionutil.go
View File

@@ -177,7 +177,11 @@ func FetchMavenWithNeoForgeStyleVersions(url string, friendlyName string) func(m
if len(mcSplit) > 2 { if len(mcSplit) > 2 {
mcMinor = mcSplit[2] mcMinor = mcSplit[2]
} }
return strings.HasPrefix(neoforgeVersion, mcMajor+"."+mcMinor)
// We can only accept an exact version number match, because otherwise 1.21.1 would pull in loader versions for 1.21.10.
var requiredPrefix = mcMajor + "." + mcMinor + "."
return strings.HasPrefix(neoforgeVersion, requiredPrefix)
}) })
} }