diff --git a/src/main/java/link/infra/packwiz/installer/request/HandlerManager.java b/src/main/java/link/infra/packwiz/installer/request/HandlerManager.java index 4112522..31f8ab8 100644 --- a/src/main/java/link/infra/packwiz/installer/request/HandlerManager.java +++ b/src/main/java/link/infra/packwiz/installer/request/HandlerManager.java @@ -30,6 +30,10 @@ public abstract class HandlerManager { } return loc; } + + // TODO: What if files are read multiple times?? + // Zip handler discards once read, requesting multiple times on other handlers would cause multiple downloads + // Caching system? Copy from already downloaded files? public static InputStream getFileInputStream(URI loc) throws Exception { for (IRequestHandler handler : handlers) { diff --git a/src/main/java/link/infra/packwiz/installer/request/IRequestHandler.java b/src/main/java/link/infra/packwiz/installer/request/IRequestHandler.java index e2896c3..aaf48b5 100644 --- a/src/main/java/link/infra/packwiz/installer/request/IRequestHandler.java +++ b/src/main/java/link/infra/packwiz/installer/request/IRequestHandler.java @@ -16,6 +16,7 @@ public interface IRequestHandler { /** * Gets the InputStream for a location. Must be threadsafe. + * It is assumed that each location is read only once for the duration of an IRequestHandler. * @param loc The location to be read * @return The InputStream containing the data of the file * @throws Exception diff --git a/src/main/java/link/infra/packwiz/installer/request/handlers/RequestHandlerHTTP.java b/src/main/java/link/infra/packwiz/installer/request/handlers/RequestHandlerHTTP.java index 0eb2263..1cde9f9 100644 --- a/src/main/java/link/infra/packwiz/installer/request/handlers/RequestHandlerHTTP.java +++ b/src/main/java/link/infra/packwiz/installer/request/handlers/RequestHandlerHTTP.java @@ -1,8 +1,6 @@ package link.infra.packwiz.installer.request.handlers; -import java.io.IOException; import java.io.InputStream; -import java.net.MalformedURLException; import java.net.URI; import java.net.URLConnection;